-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove implicit groups #292
Conversation
@d-v-b, is this PR ready for review? |
@MSanKeys963 yes! |
how can we move forward with this? I think it's important to make these changes quickly, before we get skew between implementations. |
@zarr-developers/steering-council - this PR has sat without review for 4 months. Can we move it forward please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the push @jhamman.
@d-v-b: do you want to take a look at the conflict? |
…into no_implicit_groups
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @d-v-b.
Merging as an agreed upon "adjustment" of v3 needed to a "spec bug" introduced by removing the concept of a root directory without re-evaluating the explicit/implicit concept.
This is a change that all implementors need to be aware of. See the list of "Changes after Provisional Acceptance" for other such items.
cc: @zarr-developers/implementation-council
this PR removes support for implicit groups (Zarr groups with no metadata documentation) from the spec. See #291 for the motivation. Besides changing the content of the text, I don't know what else to change, so I'm keeping this a draft for now.
A mergeable version of this PR would include a section explaining what implicit groups are, why they were added previously, and why they are now removed. I am happy to add this if it looks like this PR has legs.
Related discussion: #184