-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a list of codecs
in place of a single compressor
field
#153
Conversation
I am very much in favour of this idea |
This makes sense to me too. |
There is an implicit assumption here, that if the last codec in an encoding chain still produces an array as opposed to bytes (or the list is empty), then the output to storage is the bytes (memory buffer) of that array. That's like the "null" or "dummy" codec mentioned elsewhere. I don't think we need that codes if we are explicit about it here. |
|
Perfect, thanks @jbms |
LGTM as well. Is there missing anything for this to be merged? cc @joshmoore @MSanKeys963 @alimanfoo @jakirkham We can cherry-pick the change onto the ZEP1-review branch then as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well 👍
Merging per all the 👍s. One thing this does make me aware of though, is that we should probably start maintaining a list of explicit changes now before the list becomes too long to be applied to the existing V3 implementations. |
Per what seemed to be the consensus reached at the zarr meeting on 2022-07-27, this replaces the
compressor
field in the array metadata with acodecs
field that can specify a list of codecs.