Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a complete step to the test CI #2521

Merged
merged 3 commits into from
Dec 5, 2024
Merged

add a complete step to the test CI #2521

merged 3 commits into from
Dec 5, 2024

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Nov 29, 2024

Adds a "test complete" step to the test CI pipeline so that we can use that as a requirement for auto-merging.

@normanrz normanrz marked this pull request as ready for review November 29, 2024 19:15
@normanrz normanrz requested a review from jhamman November 29, 2024 19:15
@normanrz normanrz self-assigned this Nov 29, 2024
@normanrz normanrz requested a review from d-v-b November 29, 2024 19:15
@dstansby
Copy link
Contributor

dstansby commented Dec 1, 2024

Ooh I like this, is the idea not to have to update the required GH actions jobs every time a test name changes (e.g., when a Python version is updated)?

@normanrz
Copy link
Member Author

normanrz commented Dec 2, 2024

Exactly. This should make it easier to define required CI runs for Github's auto-merge functionality without having to select all runs in all matrix configurations.

@jhamman
Copy link
Member

jhamman commented Dec 5, 2024

Let's give this a try.

@dstansby dstansby merged commit ae6e8e6 into main Dec 5, 2024
32 checks passed
@normanrz normanrz deleted the gh-complete branch December 5, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants