Revert "Fix is_total_slice for size-1 dimensions (#1800)"
#1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 9d046ea.
dcherian
commented
May 16, 2024
| @@ -234,17 +234,8 @@ def is_total_slice(item, shape: Tuple[int]) -> bool: | |||
| if isinstance(item, tuple): | |||
| return all( | |||
| ( | |||
| ( | |||
There was a problem hiding this comment.
Alternatively I could comment this out and add a TODO
There was a problem hiding this comment.
From my side, +1 for reverting. We can also revert the revert.
|
I lean toward failing forward on this issue. #1875 is looking good so I think we should get that out, rather than revert. |
|
As you wish :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9d046ea.
Closes #1874 by reverting #1800
TODO: