Fix agent mutation of new registry #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason we wouldn't just add the correct agent ignore label to the pod all the time vs hardcode a special exemption that would still hit the webhook? |
|
We could do that too (this seemed easier at first). Lemme flip it around. |
|
@jeff-mccoy done (you were right this time) |
jeff-mccoy
requested changes
Oct 7, 2022
There was a problem hiding this comment.
I think we need to use ignore/skip zarf.dev/agent=ignore here instead. Reason for this is if the agent and registry both died due to node failures, you'd be stuck in a pending state with "patched" waiting for the agent whereas ignore wouldn't depend on the agent existing at all.
|
Changed |
jeff-mccoy
approved these changes
Oct 7, 2022
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description This is a hotfix related to the image SHASUMs introduced recently to not mutate the zarf registry on a zarf reinit. ## Related Issue Fixes # N/A ## Type of change - [X] Bug fix (non-breaking change which fixes an issue) ## Checklist before merging - [X] (Optional) Changes have been linted locally with [golangci-lint](https://github.com/golangci/golangci-lint). (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.) Co-authored-by: Megamind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a hotfix related to the image SHASUMs introduced recently to not mutate the zarf registry on a zarf reinit.
Related Issue
Fixes # N/A
Type of change
Checklist before merging