Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to show sbom files during a package inspect command #678

Merged
merged 5 commits into from
Aug 22, 2022

Conversation

YrrepNoj
Copy link
Contributor

Description

This PR adds an optional flag to display SBOM information when inspecting a Zarf package. This gives users the ability to see SBOM information before they run a zarf package deploy command.

Fixes #677

@jeff-mccoy
Copy link
Contributor

Would you mind dropping a screenshot in the PR comments when you get a chance?

@YrrepNoj
Copy link
Contributor Author

YrrepNoj commented Aug 17, 2022

Screenshot of inspecting a package that has images included
Screen Shot 2022-08-16 at 9 01 51 PM

Screenshot of inspecting a package without images
Screen Shot 2022-08-16 at 9 05 25 PM

src/cmd/package.go Show resolved Hide resolved
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great add, txh

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) August 22, 2022 05:25
@jeff-mccoy jeff-mccoy merged commit cd27f19 into master Aug 22, 2022
@jeff-mccoy jeff-mccoy deleted the qol/show-sbom-on-package-inspect branch August 22, 2022 05:41
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
* add flag to show sbom files during a package inspect command
* update docs for new inspect command flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspecting a package should let you see the SBOM information within the package
3 participants