Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sign-off label to banned labels list to prevent merge #491

Merged
merged 3 commits into from
May 27, 2022

Conversation

YrrepNoj
Copy link
Contributor

This flag will be used when an outside contributor makes a PR and a member of the team still needs to sign-off on their commits.

@YrrepNoj YrrepNoj requested a review from jeff-mccoy May 25, 2022 15:11
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we should do a PR at some point to just update https://github.com/yogevbd/enforce-label-action/blob/master/src/main.ts#L19 to support regex or at least prefix-matching so we could just do needs-

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) May 27, 2022 19:10
@jeff-mccoy jeff-mccoy merged commit b0602d6 into master May 27, 2022
@jeff-mccoy jeff-mccoy deleted the add-blocking-sign-off-flag branch May 27, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants