Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: debug template print #3171

Merged
merged 3 commits into from
Nov 5, 2024
Merged

refactor: debug template print #3171

merged 3 commits into from
Nov 5, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

We were manually putting together a json, refactored this to edit the object then marshall/log the json direct

Related Issue

Relates to #2576

Checklist before merging

@AustinAbro321 AustinAbro321 requested review from a team as code owners November 1, 2024 12:23
@netlify Netlify
Copy link

netlify bot commented Nov 1, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 08a5ba6
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/672a28ef316d9c000837e897

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/template/template.go 36.36% 14 Missing ⚠️
src/pkg/packager/creator/normal.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/creator/normal.go 6.94% <0.00%> (-0.02%) ⬇️
src/internal/packager/template/template.go 10.89% <36.36%> (-52.55%) ⬇️

... and 3 files with indirect coverage changes

mkcp
mkcp requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mkcp mkcp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change overall and glad you took on adding tests. I had some feedback abt. the way you're testing with data. There's some "unhappy path" cases with nils and empties that we can cover easier with the test table pattern.

src/internal/packager/template/template.go Show resolved Hide resolved
src/internal/packager/template/template_test.go Outdated Show resolved Hide resolved
@AustinAbro321
better test template
08a5ba6 
Signed-off-by: Austin Abro <[email protected]>
mkcp
mkcp approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 6a55bc3 Nov 5, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the refactor-debug-template-print branch November 5, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcp mkcp mkcp approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AustinAbro321 @mkcp