Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove progressbar on image push #3110

Merged
merged 4 commits into from
Oct 17, 2024
Merged

feat: remove progressbar on image push #3110

merged 4 commits into from
Oct 17, 2024

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Oct 16, 2024 •
edited
Loading

Description

Removing the progressbar on image push as we believe that it is causing Zarf to drop the connection to the registry on large image pushes.

Related Issue

Relates to #2864 #2104

Checklist before merging

@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit aaca9ef
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/671014c54f9f5200084a4b80

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/images/common.go 0.00% 6 Missing ⚠️
src/internal/packager2/mirror.go 0.00% 5 Missing ⚠️
src/internal/packager/images/push.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager/images/push.go 0.00% <0.00%> (ø)
src/internal/packager2/mirror.go 0.00% <0.00%> (ø)
src/internal/packager/images/common.go 41.17% <0.00%> (ø)

@AustinAbro321 AustinAbro321 changed the title Remove progressbar on push feat: replace progressBar with spinner on push Oct 16, 2024
@AustinAbro321 AustinAbro321 changed the title feat: replace progressBar with spinner on push feat: replace progressbar with spinner on push Oct 16, 2024
@AustinAbro321
use spinner
1c4e43a 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review October 16, 2024 18:36
@AustinAbro321 AustinAbro321 requested review from a team as code owners October 16, 2024 18:36
@AustinAbro321
make diff easier to read
9fc3e58 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
back to message.info
aaca9ef 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 changed the title feat: replace progressbar with spinner on push feat: remove progressbar on image push Oct 16, 2024
schristoff
schristoff approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf gj

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 99209cf Oct 17, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the remove-progressbar-on-push branch October 17, 2024 15:32
mjnagel pushed a commit to mjnagel/zarf that referenced this pull request Oct 21, 2024
@AustinAbro321 @mjnagel
feat: remove progressbar on image push (zarf-dev#3110)
2194524 
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Micah Nagel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AustinAbro321 @schristoff