Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GitOps E2E test more robust + minor cleanup #310

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Make GitOps E2E test more robust + minor cleanup #310

merged 2 commits into from
Feb 9, 2022

Conversation

RothAndrew
Copy link
Contributor

  • Make GitOps E2E test more robust by using a newer tag that got created after the major force push to master
  • Minor cleanup of dead code

@RothAndrew
Make GitOps E2E test more robust + minor cleanup1
0d419c5 
- Make GitOps E2E test more robust by using a newer tag that got created after the major force push to master
- Minor cleanup of dead code
@RothAndrew RothAndrew self-assigned this Feb 9, 2022
@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew RothAndrew enabled auto-merge (squash) February 9, 2022 23:19
@RothAndrew
Copy link
Contributor Author

@jeff-mccoy Here's the scoped down PR for just the E2E test changes. The other one will get smaller once master gets integrated including this change

jeff-mccoy
jeff-mccoy approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jeff-mccoy
Copy link
Contributor

I'm a little sad you didn't stay on the dark side 😂 but 👍.

@RothAndrew
Copy link
Contributor Author

Gotta set a good example for the younglings 😉

@RothAndrew RothAndrew merged commit fe2319c into master Feb 9, 2022
@RothAndrew RothAndrew deleted the feature/fix-broken-e2e-test branch February 9, 2022 23:37
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@RothAndrew
Make GitOps E2E test more robust + minor cleanup (#310)
9f21037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

@wadedesir wadedesir Awaiting requested review from wadedesir

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees

@RothAndrew RothAndrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RothAndrew @jeff-mccoy