Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --confirm flag description for init and package deploy cmd #1602

Conversation

Madeline-UX
Copy link
Contributor

Description

Current Command descriptions are not specific to the consequences that command may have including

Skips prompts to review SBOM
configure variables
select optional components
review potential breaking changes.

Adds warning and more specific language to flag

Updated to
--Confirm - Confirms package deployment without prompting. ONLY use with packages you trust. Skips prompts to review SBOM, configure variables, select optional components and review potential breaking changes.
...

Related Issue

Relates to #1600

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 10a90f5
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6439c615ef8fe700083ddc8c
😎 Deploy Preview https://deploy-preview-1602--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Racer159
Racer159 previously approved these changes Apr 14, 2023
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: razzle <[email protected]>
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 3b37eb5 into main Apr 14, 2023
@Racer159 Racer159 deleted the 1600-update-confirm-flag-description-to-include-warning-and-recommendation branch April 14, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update --confirm flag description to include warning and recommendation
3 participants