Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass package architecture around through ImgConfigs #1497

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Pass package architecture around through ImgConfigs #1497

merged 4 commits into from
Mar 30, 2023

Conversation

Racer159
Copy link
Contributor

Description

This ensures that ImgConfigs always carry their architecture down to Crane.

Related Issue

Fixes #N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 added the needs-tests PR Label - Tests required to merge label Mar 28, 2023
@netlify
Copy link

netlify bot commented Mar 28, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit b804a21
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6425e5a4c7cb5c000841c660

@Racer159 Racer159 changed the title Pass package architecture around through ImGConfigs Pass package architecture around through ImgConfigs Mar 28, 2023
YrrepNoj
YrrepNoj approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me.

@Racer159 Racer159 removed the needs-tests PR Label - Tests required to merge label Mar 30, 2023
@Racer159 Racer159 enabled auto-merge (squash) March 30, 2023 20:41
@Racer159 Racer159 merged commit 9a7cd42 into main Mar 30, 2023
@Racer159 Racer159 deleted the hotfix-architecture-metadata branch March 30, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Racer159 @YrrepNoj