Better Docker Daemon Support + Cleaner Actions Terminal Output #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
YrrepNoj
force-pushed
the
docker-playground
branch
from
c630fa9
to
c03e876
Compare
Racer159
requested changes
Feb 7, 2023
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
jeff-mccoy
changed the title
YrrepNoj
previously approved these changes
Feb 8, 2023
|
@jeff-mccoy Appreciate the addition of the warning regarding the file size and suggestions for how they can optimize in docs - need to make sure that link never dies lol |
Madeline-UX
previously approved these changes
Feb 8, 2023
Time to clean up everyone Let's pick up our things Clean up Everybody clean up, clean up Everybody clean up, clean up Everybody clean up Time to clean up Pick up Everybody pick up, pick up Everybody pick up, pick up Everybody pick up Time to pick up Pick up the toys, put them away Pick up the box, put them away Pick up the books, put them away Put your things away Pick up the toys, put them away Pick up the box, put them away Pick up the books, put them away Put your things away Clean up Everybody clean up, clean up Everybody clean up, clean up Everybody clean up Time to clean up Pick up Everybody pick up, pick up Everybody pick up, pick up Everybody pick up Time to pick up Pick up the toys, put them away Pick up the box, put them away Pick up the books, put them away Put your things away Pick up the toys, put them away Pick up the box, put them away Pick up the books, put them away Put your things away
jeff-mccoy
dismissed stale reviews from Racer159, Madeline-UX, and YrrepNoj
via
632858d
jeff-mccoy
force-pushed
the
docker-playground
branch
from
d58d2b5
to
632858d
Compare
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Updates local image behavior, changing back to crane first with docker as an optional fallback when needed. Large images from docker will still be slow, but should not cause OOM issues and a new warning was added to communicate an alternate approach to speed up local dev with large images. Also cleans up some of the exec package presentation logic. ## Related Issue Fixes #1214 Fixes #1267 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates local image behavior, changing back to crane first with docker as an optional fallback when needed. Large images from docker will still be slow, but should not cause OOM issues and a new warning was added to communicate an alternate approach to speed up local dev with large images. Also cleans up some of the exec package presentation logic.
Related Issue
Fixes #1214
Fixes #1267
Type of change
Checklist before merging