Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter Zarf Registry HPA behavior #1317

Merged
merged 19 commits into from
Feb 3, 2023
Merged

Smarter Zarf Registry HPA behavior #1317

merged 19 commits into from
Feb 3, 2023

Conversation

jeff-mccoy
Copy link
Contributor

@jeff-mccoy jeff-mccoy commented Feb 1, 2023

Make Registry HPA less aggressive and block from downscaling while running zarf package deploy if images exist.

Related Issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 2a1a57c
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/63dd4e2b351b7f0008f8446d

@jeff-mccoy
Copy link
Contributor Author

During deploy, scaleDown disabled:
Screenshot 2023-02-01 at 7 20 27 PM

After deploy, scaleDown reset:
Screenshot 2023-02-01 at 7 20 33 PM

src/pkg/k8s/hpa.go Outdated Show resolved Hide resolved
src/pkg/packager/deploy.go Outdated Show resolved Hide resolved
src/pkg/packager/deploy.go Outdated Show resolved Hide resolved
YrrepNoj
YrrepNoj previously approved these changes Feb 3, 2023
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a single 'nit' over a function name.

Since it seems like just a nit, I'll approve the PR and leave resolving that to your judgement :)

src/internal/cluster/zarf.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jeff-mccoy jeff-mccoy merged commit e71f968 into main Feb 3, 2023
@jeff-mccoy jeff-mccoy deleted the smarter-registry-hpa branch February 3, 2023 19:53
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Make Registry HPA less aggressive and block from downscaling while
running `zarf package deploy` if images exist.

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants