Refactor git repository caching logic #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for zarf-docs failed.
|
YrrepNoj
changed the title
YrrepNoj
requested review from
jeff-mccoy,
Racer159,
JasonvanBrackel and
RothAndrew
as code owners
jeff-mccoy
changed the title
jeff-mccoy
reviewed
Feb 1, 2023
jeff-mccoy
reviewed
Feb 1, 2023
jeff-mccoy
reviewed
Feb 1, 2023
jeff-mccoy
reviewed
Feb 1, 2023
jeff-mccoy
reviewed
Feb 1, 2023
jeff-mccoy
reviewed
Feb 1, 2023
jeff-mccoy
reviewed
Feb 1, 2023
jeff-mccoy
reviewed
Feb 1, 2023
✅ Deploy Preview for zarf-docs canceled.
|
YrrepNoj
force-pushed
the
1069-update-repo-cache
branch
from
84210a9
to
f3391c0
Compare
jeff-mccoy
reviewed
Feb 2, 2023
jeff-mccoy
approved these changes
Feb 3, 2023
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description MISC: - Added more error handling to our git functions (one more step in our path away from using `fatal`. --- Fixes #1069 - Fix a bug where cached repos HEADs were not getting updated when the upstream repo had new changes (we were fetching the changes but not updating the branch) so they were not getting deployed correctly --- Fixes #1302 - Fix bug where additional unwanted tags where getting fetched when we were updating the HEAD of repos in `~/.zarf-cache/repos` --- Fixes #1303 - Change how we calculate the checksums of git repos - NOTE: This can be considered a breaking change... --- ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MISC:
fatal.Fixes #1069
Fixes #1302
~/.zarf-cache/reposFixes #1303