Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add common insecure flag #1280

Merged
merged 17 commits into from
Feb 2, 2023
Merged

add common insecure flag #1280

merged 17 commits into from
Feb 2, 2023

Conversation

jeff-mccoy
Copy link
Contributor

Migrated from #1191

Description

Adding support for insecure flag for external registry in zarf init. Fixing zarf package create and zarf package deploy failures with external self signed cert registry as mentioned in #1190 and #1181

Related Issue

Fixes # #1190
Fixes # #1181
Fixes # #561
Fixes # #1015

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing we had talked about earlier

src/cmd/root.go Show resolved Hide resolved
Co-authored-by: Wayne Starr <[email protected]>
Racer159
Racer159 previously approved these changes Jan 30, 2023
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

YrrepNoj
YrrepNoj previously approved these changes Jan 30, 2023
@Racer159 Racer159 dismissed stale reviews from YrrepNoj and themself via 80cb408 January 30, 2023 21:25
Racer159
Racer159 previously approved these changes Jan 30, 2023
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (again)

YrrepNoj
YrrepNoj previously approved these changes Jan 31, 2023
@jeff-mccoy jeff-mccoy dismissed stale reviews from YrrepNoj and Racer159 via e646e90 January 31, 2023 23:21
@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 1794283
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/63db33a559ff61000847b175

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad pandas on -k, but lgtm

@jeff-mccoy jeff-mccoy merged commit a0b1394 into main Feb 2, 2023
@jeff-mccoy jeff-mccoy deleted the fix-insecure-registry branch February 2, 2023 05:44
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Migrated from #1191

## Description
Adding support for insecure flag for external registry in `zarf init`.
Fixing `zarf package create` and `zarf package deploy` failures with
external self signed cert registry as mentioned in
#1190 and
#1181

## Related Issue

Fixes # #1190
Fixes # #1181
Fixes # #561
Fixes # #1015

---------

Co-authored-by: Rishi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants