Working Longhorn Example #1264
Merged
Working Longhorn Example #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonvanBrackel
requested review from
Madeline-UX,
RothAndrew,
jeff-mccoy,
YrrepNoj and
Racer159
as code owners
|
Definitely should do the annotation for the service so a user may access the API. |
|
NIce, I didn't realize how big it was 😆. Can we drop a couple of screenshots of this in action since we don't have a test for it right now? |
I'm using the upstream helm chart, I'll have to see if there's a helm value to add the annotation. I'll think it through if not. |
Sure thing |
|
Here's some screens from the twitch stream where I was working on it. |
|
@jeff-mccoy screenshots there and @wirewc connect added |
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Add to Longhorn to Zarf Examples ## Related Issue Relates to #854 as longhorn will be used as the backing storage for this ZarfInitPackage ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add to Longhorn to Zarf Examples
Related Issue
Relates to #854 as longhorn will be used as the backing storage for this ZarfInitPackage
Type of change
Checklist before merging