Fix external registry issues #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
requested review from
jeff-mccoy,
YrrepNoj,
JasonvanBrackel and
RothAndrew
as code owners
|
Added breaking change since this will be minorly breaking as is for people who use an in cluster external registry |
|
Dropping the breaking change label after some more testing. It will update the state correctly on upgrade. |
jeff-mccoy
reviewed
Jan 29, 2023
jeff-mccoy
reviewed
Jan 29, 2023
jeff-mccoy
reviewed
Jan 29, 2023
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description This refactors a lot of how we interact with registries (particularly external ones) to address the following bugs: - The inability to use registries external to the current cluster - The inability to set the NodePort of the internal Zarf registry ## Type of change - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [X] Test, docs, adr added or updated as needed - [X] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors a lot of how we interact with registries (particularly external ones) to address the following bugs:
Related Issue
Fixes #N/A
Type of change
Checklist before merging