Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docs site #1219

Merged
merged 18 commits into from
Jan 27, 2023
Merged

Migrate docs site #1219

merged 18 commits into from
Jan 27, 2023

Conversation

bdfinst
Copy link
Contributor

@bdfinst bdfinst commented Jan 19, 2023

Description

Move zarf-docs website into the zarf repository

Type of change

  • Refactor

Checklist before merging

  • Test, docs, adr added or updated as needed
--- PASS: TestYOLOMode (52.77s)
PASS
ok  	github.com/defenseunicorns/zarf/src/test/e2e	612.092s

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one last change request from me

jeff-mccoy
jeff-mccoy previously approved these changes Jan 26, 2023
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@jeff-mccoy
Copy link
Contributor

@bdfinst need all your git commits to be signed before we can merge.

@bdfinst
Copy link
Contributor Author

bdfinst commented Jan 26, 2023

Weird. I thought I had signing set up. Let me double-check.
Can we not configure the repo to reject unsigned?

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff-mccoy jeff-mccoy merged commit edde791 into main Jan 27, 2023
@jeff-mccoy jeff-mccoy deleted the Migrate-docs-site branch January 27, 2023 01:25
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Move zarf-docs website into the zarf repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants