-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap the crane command to make it easier to use with Zarf #1205
Wrap the crane command to make it easier to use with Zarf #1205
Conversation
This is a great short-term add, I was actually thinking maybe we should just add a more top-level command to interact with artifacts/assets zarf deploys. Something like |
I think that could make sense, though we would likely need to pull that info from the zarf state instead of the actual service. Doing that for git repos might get tricky across git hosts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lint error in tools.go
. Also, since we're adding custom logic outside of just crane, we should add a test for this. Fortunately we also need this function in the src/test/e2e/21_connect_test.go
test, so might be able to just drop it in there.
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
## Description This wraps the crane command so that it is easier to use more directly with Zarf ## Related Issue Fixes #1186 ## Type of change - [X] New feature (non-breaking change which adds functionality) ## Checklist before merging - [X] Documentation has been updated as necessary (add the `needs-docs` label)
Description
This wraps the crane command so that it is easier to use more directly with Zarf
Related Issue
Fixes #1186
Type of change
Checklist before merging
needs-docs
label)