Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the crane command to make it easier to use with Zarf #1205

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

Racer159
Copy link
Contributor

Description

This wraps the crane command so that it is easier to use more directly with Zarf

Related Issue

Fixes #1186

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before merging

  • Documentation has been updated as necessary (add the needs-docs label)

@jeff-mccoy
Copy link
Contributor

This is a great short-term add, I was actually thinking maybe we should just add a more top-level command to interact with artifacts/assets zarf deploys. Something like zarf artifact images orzarf assets images. I think it should probably be view-only since mutation would break the nature of declarative packages. Also zarf artifact repos. Thoughts?

@Racer159
Copy link
Contributor Author

I think that could make sense, though we would likely need to pull that info from the zarf state instead of the actual service. Doing that for git repos might get tricky across git hosts.

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lint error in tools.go. Also, since we're adding custom logic outside of just crane, we should add a test for this. Fortunately we also need this function in the src/test/e2e/21_connect_test.go test, so might be able to just drop it in there.

@Racer159
Copy link
Contributor Author

There's a lint error in tools.go. Also, since we're adding custom logic outside of just crane, we should add a test for this. Fortunately we also need this function in the src/test/e2e/21_connect_test.go test, so might be able to just drop it in there.

Fixed

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) January 17, 2023 16:49
@jeff-mccoy jeff-mccoy merged commit ede3504 into main Jan 17, 2023
@jeff-mccoy jeff-mccoy deleted the 1186-make-it-easier-to-view-contents-of-registry branch January 17, 2023 17:01
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
## Description

This wraps the crane command so that it is easier to use more directly
with Zarf

## Related Issue

Fixes #1186 

## Type of change

- [X] New feature (non-breaking change which adds functionality)

## Checklist before merging

- [X] Documentation has been updated as necessary (add the `needs-docs`
label)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to view contents of registry
2 participants