Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push both a crc and non-crc image tag for zarf images #1203

Merged

Conversation

Racer159
Copy link
Contributor

Description

Pushes both a CRC hashed and non-CRC hashed image from Zarf. Also improves testing of connect logic.

Related Issue

Fixes #1143

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and additional test logic is great!

@jeff-mccoy jeff-mccoy merged commit 75f1229 into main Jan 14, 2023
@jeff-mccoy jeff-mccoy deleted the 1143-option-for-non-crc-hashed-images-in-zarf-registry branch January 14, 2023 23:44
jeff-mccoy pushed a commit that referenced this pull request Jan 15, 2023
## Description

Pushes both a CRC hashed and non-CRC hashed image from Zarf. Also
improves testing of connect logic.

## Related Issue

Fixes #1143 

## Type of change

- [X] Bug fix (non-breaking change which fixes an issue)

## Checklist before merging

- [X] Tests have been added/updated as necessary (add the `needs-tests`
label)
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
## Description

Pushes both a CRC hashed and non-CRC hashed image from Zarf. Also
improves testing of connect logic.

## Related Issue

Fixes #1143 

## Type of change

- [X] Bug fix (non-breaking change which fixes an issue)

## Checklist before merging

- [X] Tests have been added/updated as necessary (add the `needs-tests`
label)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for non-CNC hashed images in Zarf registry
2 participants