Cleanup Typography + utilize new Typography system from Unicorn UI #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noxsios
requested review from
mike-winberry,
Racer159,
jeff-mccoy and
YrrepNoj
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
jeff-mccoy
reviewed
Jan 17, 2023
jeff-mccoy
reviewed
Jan 17, 2023
720p.1199.mov@jeff-mccoy watch unmuted |
jeff-mccoy
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
@Noxsios raising the bar on async PR review process. Also lgtm.
Noxsios
added a commit
that referenced
this pull request
Mar 8, 2023
…1199) ## Description Utilizes new Typography system from @mike-winberry : https://unicorn-ui.netlify.app/theme - Replaces current global theming via `app.css` w/ an implementation in `typography.ts` - Performs overrides to stay in harmony with the Figma spec laid out by @Madeline-UX ### Additions: - Remove dead `Container` and `Modal` components - Replace any leftover `<p>` and `<hX` elements w/ Typography
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Utilizes new Typography system from @mike-winberry : https://unicorn-ui.netlify.app/theme
app.cssw/ an implementation intypography.tsAdditions:
ContainerandModalcomponents<p>and<hXelements w/ Typography