Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize timeouts for helm actions and improve remove behavior #1188

Merged
merged 13 commits into from
Jan 13, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Jan 11, 2023

Description

This PR standardizes helm action timeouts and improves chart removal behavior.

Related Issue

Fixes #1063

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)

src/internal/packager/helm/chart.go Show resolved Hide resolved
src/pkg/k8s/secrets.go Outdated Show resolved Hide resolved
src/pkg/packager/remove.go Show resolved Hide resolved
src/pkg/packager/remove.go Outdated Show resolved Hide resolved
@jeff-mccoy jeff-mccoy merged commit 06cb31b into main Jan 13, 2023
@jeff-mccoy jeff-mccoy deleted the 1063-zarf-remove-timeout-behavior branch January 13, 2023 06:53
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
)

This PR standardizes helm action timeouts and improves chart removal
behavior.

## Related Issue

Fixes #1063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zarf remove timeout behavior
3 participants