Cleanup Icon component implementation #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noxsios
requested review from
mike-winberry,
Racer159,
jeff-mccoy and
YrrepNoj
as code owners
jeff-mccoy
pushed a commit
that referenced
this pull request
Jan 15, 2023
The `icon.svelte` component has a re-implementation of the `material-symbols` library. Since the library exports a [typescript type](https://github.com/marella/material-symbols/blob/main/material-symbols/index.d.ts), a wrapper component around this should be used instead. There is also a fallback for Zarf-specific icons (such as `package` and `component`).
Noxsios
added a commit
that referenced
this pull request
Mar 8, 2023
The `icon.svelte` component has a re-implementation of the `material-symbols` library. Since the library exports a [typescript type](https://github.com/marella/material-symbols/blob/main/material-symbols/index.d.ts), a wrapper component around this should be used instead. There is also a fallback for Zarf-specific icons (such as `package` and `component`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
icon.sveltecomponent has re-implementation of thematerial-symbolslibrary. Since the library exports a typescript type, a wrapper component around this should be used instead. There is also a fallback for Zarf specific icons (such aspackageandcomponent).Type of change