Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

803 add component descriptions to the required components in the init config package #1179

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Jan 9, 2023

Description

Adds detailed descriptions to init package components. Also updates alignment of UI that displays these components in an accordion. Also add another line break between the YAML component printed to the console and the component description.

Component descriptions are taken from this comment by @Madeline-UX : #803 (comment)

Related Issue

Fixes #803

Type of change

  • New feature (non-breaking change which adds functionality)

@Noxsios
Copy link
Contributor Author

Noxsios commented Jan 9, 2023

Screenshot 2023-01-09 at 5 54 02 PM

Screenshot 2023-01-09 at 5 54 53 PM

Madeline-UX
Madeline-UX previously approved these changes Jan 9, 2023
packages/zarf-injector/zarf.yaml Outdated Show resolved Hide resolved
packages/zarf-agent/zarf.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many plurals in one of the descriptions

packages/zarf-agent/zarf.yaml Outdated Show resolved Hide resolved
packages/zarf-agent/zarf.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeff-mccoy jeff-mccoy merged commit a471f26 into main Jan 15, 2023
@jeff-mccoy jeff-mccoy deleted the 803-add-component-descriptions-to-the-required-components-in-the-init-config-package branch January 15, 2023 05:45
jeff-mccoy added a commit that referenced this pull request Jan 15, 2023
… config package (#1179)

Adds detailed descriptions to init package components. Also updates
alignment of UI that displays these components in an accordion. Also add
another line break between the YAML component printed to the console and
the component description.

Component descriptions are taken from this comment by @Madeline-UX :
#803 (comment)

Fixes #803 

Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Megamind <[email protected]>
@Noxsios Noxsios added this to the Zarf UI milestone Jan 17, 2023
Noxsios added a commit that referenced this pull request Mar 8, 2023
… config package (#1179)

Adds detailed descriptions to init package components. Also updates
alignment of UI that displays these components in an accordion. Also add
another line break between the YAML component printed to the console and
the component description.

Component descriptions are taken from this comment by @Madeline-UX :
#803 (comment)

Fixes #803 

Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Megamind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Add component descriptions to the required components in the Init config package.
6 participants