-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
803 add component descriptions to the required components in the init config package #1179
Merged
jeff-mccoy
merged 17 commits into
main
from
803-add-component-descriptions-to-the-required-components-in-the-init-config-package
Jan 15, 2023
Merged
803 add component descriptions to the required components in the init config package #1179
jeff-mccoy
merged 17 commits into
main
from
803-add-component-descriptions-to-the-required-components-in-the-init-config-package
Jan 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noxsios
requested review from
mike-winberry,
Racer159,
jeff-mccoy and
YrrepNoj
as code owners
January 9, 2023 22:53
Madeline-UX
previously approved these changes
Jan 9, 2023
…ed-components-in-the-init-config-package
Racer159
requested changes
Jan 10, 2023
Racer159
reviewed
Jan 10, 2023
Co-authored-by: Wayne Starr <[email protected]>
runyontr
reviewed
Jan 10, 2023
…ed-components-in-the-init-config-package
YrrepNoj
previously requested changes
Jan 11, 2023
…ed-components-in-the-init-config-package
…ed-components-in-the-init-config-package
…ed-components-in-the-init-config-package
…ed-components-in-the-init-config-package
…ed-components-in-the-init-config-package
Racer159
requested changes
Jan 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many plurals in one of the descriptions
Co-authored-by: Wayne Starr <[email protected]>
…ed-components-in-the-init-config-package
Racer159
approved these changes
Jan 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…ed-components-in-the-init-config-package
jeff-mccoy
deleted the
803-add-component-descriptions-to-the-required-components-in-the-init-config-package
branch
January 15, 2023 05:45
jeff-mccoy
added a commit
that referenced
this pull request
Jan 15, 2023
… config package (#1179) Adds detailed descriptions to init package components. Also updates alignment of UI that displays these components in an accordion. Also add another line break between the YAML component printed to the console and the component description. Component descriptions are taken from this comment by @Madeline-UX : #803 (comment) Fixes #803 Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Megamind <[email protected]>
Noxsios
added a commit
that referenced
this pull request
Mar 8, 2023
… config package (#1179) Adds detailed descriptions to init package components. Also updates alignment of UI that displays these components in an accordion. Also add another line break between the YAML component printed to the console and the component description. Component descriptions are taken from this comment by @Madeline-UX : #803 (comment) Fixes #803 Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Megamind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds detailed descriptions to init package components. Also updates alignment of UI that displays these components in an accordion. Also add another line break between the YAML component printed to the console and the component description.
Component descriptions are taken from this comment by @Madeline-UX : #803 (comment)
Related Issue
Fixes #803
Type of change