Documentation spelling and grammar fixes. #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdfinst
requested review from
Madeline-UX,
JasonvanBrackel,
RothAndrew,
jeff-mccoy,
YrrepNoj and
Racer159
as code owners
jeff-mccoy
reviewed
Jan 11, 2023
There was a problem hiding this comment.
Since we always publish the init package and it is version-matched now, I think we should probably remove the text around making the init package, building the zarf binary or doing anything that requires make from this section. Those are things that really fit better in the developer docs I think. Thoughts?
Madeline-UX
previously approved these changes
Jan 12, 2023
jeff-mccoy
force-pushed
the
grammar-fixes
branch
from
32529dd
to
d1d44ec
Compare
|
This lgtm too, but we require commit signing for all commits; I went ahead and did the GPG signoff (preserves your authorship/date/commit wording). |
jeff-mccoy
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correcting minor issues with the docs as I go through them.
Related Issue
Type of change
Checklist before merging
needs-docslabel)