Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint hacking #1152

Merged
merged 23 commits into from
Jan 6, 2023
Merged

lint hacking #1152

merged 23 commits into from
Jan 6, 2023

Conversation

jeff-mccoy
Copy link
Contributor

@jeff-mccoy jeff-mccoy commented Jan 1, 2023 •
edited
Loading

Lint cleanup

@jeff-mccoy jeff-mccoy marked this pull request as ready for review January 4, 2023 17:12
Racer159
Racer159 requested changes Jan 5, 2023
View reviewed changes
src/internal/packager/git/url.go Outdated Show resolved Hide resolved
@Racer159 Racer159 self-requested a review January 5, 2023 01:17
Racer159
Racer159 previously approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now, though if @Noxsios / @YrrepNoj want to cleanup the rest there are only 54 now.

Racer159
Racer159 previously approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a comment about that weird constructor. We could also talk about whether comments are supposed to end in periods or not, but that seems pedantic for now since the linter no longer checks for it.

Noxsios
Noxsios reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, agree w/ @Racer159 about the periods, another inconsequential note would be whether Zarf is capitalized in comments.

@Racer159
Copy link
Contributor

Racer159 commented Jan 6, 2023

Looks good, agree w/ @Racer159 about the periods, another inconsequential note would be whether Zarf is capitalized in comments.

Just pushed a fix to add the periods and capitalize Zarf.

@Racer159 Racer159 requested a review from Noxsios January 6, 2023 17:16
Noxsios
Noxsios reviewed Jan 6, 2023
View reviewed changes
src/cmd/tools.go Show resolved Hide resolved
src/config/config.go Outdated Show resolved Hide resolved
src/internal/agent/hooks/pods.go Outdated Show resolved Hide resolved
src/internal/cluster/state.go Outdated Show resolved Hide resolved
Noxsios
Noxsios reviewed Jan 6, 2023
View reviewed changes
src/cmd/tools.go Outdated Show resolved Hide resolved
@Racer159 Racer159 requested a review from Noxsios January 6, 2023 19:09
YrrepNoj
YrrepNoj approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Racer159 Racer159 merged commit fc3a7b2 into main Jan 6, 2023
@Racer159 Racer159 deleted the lint-wars branch January 6, 2023 23:12
Noxsios added a commit that referenced this pull request Mar 8, 2023
@jeff-mccoy @Racer159 @Noxsios
lint hacking (#1152)
f37ce08 
Lint cleanup

Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: razzle <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 left review comments

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@mike-winberry mike-winberry Awaiting requested review from mike-winberry

@Noxsios Noxsios Awaiting requested review from Noxsios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeff-mccoy @Racer159 @YrrepNoj @Noxsios