Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the standardized hack dir vs .hooks #1146

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Use the standardized hack dir vs .hooks #1146

merged 2 commits into from
Dec 29, 2022

Conversation

jeff-mccoy
Copy link
Contributor

Following the K8s convention in https://pkg.go.dev/k8s.io/kubernetes/hack

Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff-mccoy jeff-mccoy merged commit abf6a56 into main Dec 29, 2022
@jeff-mccoy jeff-mccoy deleted the use-hacks-dir branch December 29, 2022 00:03
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants