Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SBOM Comparison Tool #1135

Merged
merged 27 commits into from
Jan 9, 2023
Merged

Add SBOM Comparison Tool #1135

merged 27 commits into from
Jan 9, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Dec 16, 2022

Description

This is an experimental Zarf SBOM comparison tool. Some folks have expressed interest in an easy way to compare zarf files across packages, and this lets them open json files from multiple places and see what was added, removed and changed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before merging

  • Documentation has been updated as necessary (add the needs-docs label)

@Racer159 Racer159 added needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels Dec 16, 2022
@Racer159 Racer159 removed needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge needs-design labels Jan 4, 2023
@Madeline-UX
Copy link
Contributor

@Racer159 Would you add a screen recording of how it works and what it looks like for my poor visually oriented mind?

Copy link
Contributor

@Madeline-UX Madeline-UX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for an MVP we can push with this one change

  • move the export CSV button out of top nav. Recommend adding it top right above the table.

A few UX things I want to work on in future iterations

  • SBOM tool navigation

@Racer159
Copy link
Contributor Author

Racer159 commented Jan 5, 2023

@Madeline-UX with the button moved:

image
image

Madeline-UX
Madeline-UX previously approved these changes Jan 5, 2023
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review all looks good, want to pull it down and play with the flow a little before approval. Will try to get to tonight.

@jeff-mccoy
Copy link
Contributor

I think we need to add some documentation or explanation on this view.

Screenshot 2023-01-09 at 12 20 16 PM

@Racer159
Copy link
Contributor Author

Racer159 commented Jan 9, 2023

I think we need to add some documentation or explanation on this view.

Screenshot 2023-01-09 at 12 20 16 PM

Added some docs:
image

@jeff-mccoy
Copy link
Contributor

g2g!

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) January 9, 2023 19:40
@jeff-mccoy jeff-mccoy changed the title Experimental sbom comparer Add SBOM Comparison Tool Jan 9, 2023
@jeff-mccoy jeff-mccoy merged commit 8b2167d into main Jan 9, 2023
@jeff-mccoy jeff-mccoy deleted the experimental-sbom-comparer branch January 9, 2023 19:48
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Add Zarf SBOM comparison tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants