Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YOLO mode #1105

Merged
merged 27 commits into from
Dec 16, 2022
Merged

Add YOLO mode #1105

merged 27 commits into from
Dec 16, 2022

Conversation

jeff-mccoy
Copy link
Contributor

@jeff-mccoy jeff-mccoy commented Dec 8, 2022

Provides the ability to create Zarf packages intended to work in online-only environments, i.e., without the internal Zarf airgap components typically provided by zarf init.

Related Issue

Fixes #1051
Fixes #1046
Related to #1134

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • An ADR has been written as necessary (add the needs-adr label) [ 1 2 3 ]

@jeff-mccoy jeff-mccoy added needs-adr needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels Dec 12, 2022
@jeff-mccoy
Copy link
Contributor Author

Deployment of the yolo package to a clean cluster
Screenshot 2022-12-12 at 7 11 14 PM

Failure on OCI image inclusion
Screenshot 2022-12-12 at 7 08 52 PM

Failure on git repo inclusion
Screenshot 2022-12-12 at 7 09 41 PM

@jeff-mccoy jeff-mccoy changed the title wip: add YOLO mode Add YOLO mode Dec 14, 2022
@jeff-mccoy jeff-mccoy removed needs-adr needs-docs PR Label - Docs required to merge labels Dec 15, 2022
@jeff-mccoy jeff-mccoy removed the needs-tests PR Label - Tests required to merge label Dec 15, 2022
@jeff-mccoy jeff-mccoy marked this pull request as ready for review December 15, 2022 02:28
adr/0009-yolo-mode.md Outdated Show resolved Hide resolved
@Racer159
Copy link
Contributor

Racer159 commented Dec 15, 2022

Not going to put this in the needs changes category, but this does feel like it would warrant more user messaging on deploy (i.e. a big warning note that this will attempt to pull things from an online source). A real Zarf package could look this small, and the yolo part likely wouldn't really be understood by our deploy persona on an airgapped system. In the future this could lead to confusion for what is (at least mostly still) an airgap tool @Madeline-UX for thoughts as well

@jeff-mccoy
Copy link
Contributor Author

Not going to put this in the needs changes category, but this does feel like it would warrant more user messaging on deploy (i.e. a big warning note that this will attempt to pull things from an online source). A real Zarf package could look this small, and the yolo part likely wouldn't really be understood by our deploy persona on an airgapped system. In the future this could lead to confusion for what is (at least mostly still) an airgap tool @Madeline-UX for thoughts as well

Yeah that's a good point. But also don't want to totally scare ppl off either with some big scary message. * thinking * 🤔

src/internal/packager/validate/validate.go Outdated Show resolved Hide resolved
src/pkg/packager/deploy.go Outdated Show resolved Hide resolved
src/pkg/packager/deploy.go Outdated Show resolved Hide resolved
@jeff-mccoy jeff-mccoy merged commit 79b432f into main Dec 16, 2022
@jeff-mccoy jeff-mccoy deleted the online-has-feelilngs-too branch December 16, 2022 18:04
@Madeline-UX
Copy link
Contributor

Right now the UI forces Zarf to run init before it is able to deploy a package. How might this change with YOLO mode? Is there a check in place where Zarf can see if it has access to the internet before deploying a package? Like a pre-flight check?

@Madeline-UX
Copy link
Contributor

Not going to put this in the needs changes category, but this does feel like it would warrant more user messaging on deploy (i.e. a big warning note that this will attempt to pull things from an online source). A real Zarf package could look this small, and the yolo part likely wouldn't really be understood by our deploy persona on an airgapped system. In the future this could lead to confusion for what is (at least mostly still) an airgap tool @Madeline-UX for thoughts as well

Yeah that's a good point. But also don't want to totally scare ppl off either with some big scary message. * thinking * 🤔

What about following the pattern that has already been established when Zarf downloads a package from the internet? It asks and double confirms that this is the action the user wishes to take. Considering the security posture of default to not harming a system I could see a warrant here for a check

Another option is to add a separate field or type to the packages? Maybe this has already been done and I missed it

Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Provides the ability to create Zarf packages intended to work in
online-only environments, i.e., without the internal Zarf airgap
components typically provided by `zarf init`. Also adds early FAQ.

## Related Issue
Fixes #1051 
Fixes #1046 
Related to #1134 

Co-authored-by: unclegedd <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: MxNxPx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Zarf in a Connected Environment [DOCS] Unable to find docs on the "ignore" label
6 participants