Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add a workflow that enforces PR titles follow the conventional commit spec #2390

Closed
lucasrod16 opened this issue Mar 20, 2024 · 0 comments · Fixed by #2391
Closed

ci: add a workflow that enforces PR titles follow the conventional commit spec #2390

lucasrod16 opened this issue Mar 20, 2024 · 0 comments · Fixed by #2391
Assignees
@lucasrod16

Comments

@lucasrod16
Copy link
Contributor

lucasrod16 commented Mar 20, 2024 •
edited
Loading

Describe what should be investigated or refactored

A workflow should be added to our existing CI to enforce PR titles follow the conventional commits spec

Since we squash all commits in a PR on merge, only the PR title is relevant since that becomes the single commit message when a PR is merged.

The contributing guide should also be updated to reflect this convention.

Links to any relevant code

`https://github.com/defenseunicorns/zarf/tree/main/.github/workflows

Additional context

Should follow this same general pattern:
https://github.com/defenseunicorns/kubernetes-fluent-client/blob/main/.github/workflows/commitlint.yml
@lucasrod16 lucasrod16 self-assigned this Mar 20, 2024
@lucasrod16 lucasrod16 moved this to In progress in Zarf (old) Mar 20, 2024
@lucasrod16 lucasrod16 mentioned this issue Mar 20, 2024
Merged
5 tasks
@lucasrod16 lucasrod16 moved this from In progress to In review in Zarf (old) Mar 20, 2024
Noxsios added a commit that referenced this issue Mar 21, 2024
@lucasrod16 @Noxsios
ci: add commitlint workflow and update contributing guide (#2391)
329a1ae 
## Description
add commitlint workflow and update contributing guide

## Related Issue

Fixes #2390

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: razzle <[email protected]>
@github-project-automation github-project-automation bot moved this from New to Closed in Zarf Project Board Mar 21, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Zarf (old) Mar 21, 2024
@salaxander salaxander removed this from Zarf (old) Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasrod16 lucasrod16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add commitlint workflow and update contributing guide zarf-dev/zarf
1 participant
@lucasrod16