-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zarf's message when you hit the pull rate limit isn't helpful #2081
Comments
the CI pipeline got this message today:
|
In a zarf message:
if you run docker pull directly:
it appears to be crane that doesn't expose the message from the server on failure, so the message just says nope, it's not there. we should see if there's a way to improve this, maybe a PR against crane. |
I've validated where the problem is and it's fixable within zarf. Crane hides the underlying transport info in the error, but Zarf doesn't print out the error from crane unless you have debug on. It's an actual bug, If it can't pull remotely and fails to pull locally, Zarf pull.go loses the original error unless you have debug on. |
…a remote (#2160) ## Description This fixes a bug where if zarf (via crane) can't pull an image from a remote repository, and a local tarball doesn't exist, it will output the proper error from crane, versus hiding the issue as "image does not exist" ## Related Issue Fixes #2081 <!-- or --> Relates to # ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Wayne Starr <[email protected]>
my PC (main, 0.30.1+)
Steps to reproduce
make test-e2e
too oftenworkaround is to simply login to docker.io. but still we shouldn't use it as part of our constantly run testing as much.
Expected result
it should run successfully.
Actual Result
➜ zarf git:(main) ✗ docker pull docker.io/defenseunicorns/zarf-game:multi-tile-dark
Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
Visual Proof (screenshots, videos, text, etc)
Severity/Priority
Low
The text was updated successfully, but these errors were encountered: