Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generating completion without needing to auth or configure #321

Closed
maxice8 opened this issue Jul 25, 2019 · 4 comments
Closed

Allow generating completion without needing to auth or configure #321

maxice8 opened this issue Jul 25, 2019 · 4 comments
Milestone
0.17.0

Comments

@maxice8
Copy link
Contributor

maxice8 commented Jul 25, 2019

I'm trying to package lab for Alpine Linux and i want to generate the completion on the fly as the package is built.
zaquestion added a commit that referenced this issue Jul 25, 2019
@zaquestion
#321: allow completions to be generated without authenticating with G…
c5d4454 
…itLab

This makes it easy for distributors to provide completion out of the box in packaged versions of lab
@zaquestion zaquestion added this to the 0.17.0 milestone Jul 25, 2019
@zaquestion
Copy link
Owner

I've put in a hacky allowance for this, since unfortunately I didn't make it easy to circumvent the config loading/auth path, but it should allow for this case no problem.

Ref: #323

zaquestion added a commit that referenced this issue Jul 25, 2019
@zaquestion
Merge pull request #323 from zaquestion/unauthed_completion
953e508 
#321: allow completions to be generated without authenticating with GitLab
@maxice8
Copy link
Contributor Author

maxice8 commented Jul 25, 2019

Thank you very much, although i believe the optimal state is like hub where it only does auth if you do an operation that requires it, lab has this ruby-like delay when it starts that makes it very annoying to script.

@maxice8
Copy link
Contributor Author

maxice8 commented Jul 25, 2019

wfm

@maxice8 maxice8 closed this as completed Jul 25, 2019
@zaquestion
Copy link
Owner

Yeah that's something I'm hoping to address in this release as well thats called out in #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
2 participants
@zaquestion @maxice8