cmd/util: avoid an empty string to be parsed

An additional empty string was being added in the array of "branchArgs" to
later be processed as a valid branch/remote information by the argument
parses. It wasn't an issue before because a "err" return value was being
ignored somewhere else within the parses, but the commit 69ae19e ("cmd:
fix return value checks and statements") changed it and the error finally
was cought.

Signed-off-by: Bruno Meneguele <[email protected]>

cmd/util.go

@@ -345,6 +345,8 @@ func parseArgsWithGitBranchMR(args []string) (string, int64, error) {
 	return s, i, nil
 }
 
+// filterCommentArg separate the case where a command can have both the
+// remote and "<mrID>:<commentID>" at the same time.
 func filterCommentArg(args []string) (int, []string, error) {
 	branchArgs := []string{}
 	idString := ""
@@ -359,16 +361,18 @@ func filterCommentArg(args []string) (int, []string, error) {
 		} else {
 			idString = args[0]
 		}
-	} else if len(args) > 1 {
+	} else if len(args) == 2 {
 		branchArgs = append(branchArgs, args[0])
 		idString = args[1]
+	} else {
+		return 0, branchArgs, fmt.Errorf("unsupported number of arguments")
 	}
 
 	if strings.Contains(idString, ":") {
 		ps := strings.Split(idString, ":")
 		branchArgs = append(branchArgs, ps[0])
 		idString = ps[1]
-	} else {
+	} else if idString != "" {
 		branchArgs = append(branchArgs, idString)
 		idString = ""
 	}