issue_close: Allow closing as duplicate of another issue

If an issue is opened that duplicates an existing issue, it is
useful to mark it as such rather than to just close it.

Unfortunately the functionality from gitlab's web UI isn't exposed
in the API (or I'm too clumsy to find it), but we can get around
that limitation by leveraging the corresponding quick action.

cmd/issue_close.go

@@ -3,6 +3,7 @@ package cmd
 import (
 	"fmt"
 	"log"
+	"strings"
 
 	"github.com/rsteube/carapace"
 	"github.com/spf13/cobra"
@@ -17,6 +18,9 @@ var issueCloseCmd = &cobra.Command{
 	Long:             ``,
 	Args:             cobra.MinimumNArgs(1),
 	PersistentPreRun: LabPersistentPreRun,
+	Example: `lab issue close 1234
+lab issue close --duplicate 123 1234
+lab issue close --duplicate other-project#123 1234`,
 	Run: func(cmd *cobra.Command, args []string) {
 		rn, id, err := parseArgsRemoteAndID(args)
 		if err != nil {
@@ -28,15 +32,28 @@ var issueCloseCmd = &cobra.Command{
 			log.Fatal(err)
 		}
 
-		err = lab.IssueClose(p.ID, int(id))
-		if err != nil {
-			log.Fatal(err)
+		dupId, _ := cmd.Flags().GetString("duplicate")
+		if dupId != "" {
+			if !strings.Contains(dupId, "#") {
+				dupId = "#" + dupId
+			}
+			err = lab.IssueDuplicate(p.ID, int(id), dupId)
+			if err != nil {
+				log.Fatal(err)
+			}
+			fmt.Printf("Issue #%d closed as duplicate of %s\n", id, dupId)
+		} else {
+			err = lab.IssueClose(p.ID, int(id))
+			if err != nil {
+				log.Fatal(err)
+			}
+			fmt.Printf("Issue #%d closed\n", id)
 		}
-		fmt.Printf("Issue #%d closed\n", id)
 	},
 }
 
 func init() {
+	issueCloseCmd.Flags().StringP("duplicate", "", "", "mark as duplicate of another issue")
 	issueCmd.AddCommand(issueCloseCmd)
 	carapace.Gen(issueCloseCmd).PositionalCompletion(
 		action.Remotes(),

cmd/issue_test.go

@@ -76,6 +76,48 @@ func Test_issueCmd(t *testing.T) {
 	})
 }
 
+func Test_issueCmdDuplicate(t *testing.T) {
+	var issueID string
+	t.Run("create", func(t *testing.T) {
+		repo := copyTestRepo(t)
+		cmd := exec.Command(labBinaryPath, "issue", "create", "lab-testing",
+			"-m", "issue title",
+			"-m", "issue description",
+			"-l", "bug",
+			"-l", "critical",
+			"-a", "lab-testing")
+		cmd.Dir = repo
+
+		b, err := cmd.CombinedOutput()
+		if err != nil {
+			t.Log(string(b))
+			t.Fatal(err)
+		}
+
+		out := string(b)
+		require.Contains(t, out, "https://gitlab.com/lab-testing/test/-/issues/")
+
+		i := strings.Index(out, "\n")
+		issueID = strings.TrimPrefix(out[:i], "https://gitlab.com/lab-testing/test/-/issues/")
+		t.Log(issueID)
+	})
+	t.Run("close", func(t *testing.T) {
+		if issueID == "" {
+			t.Skip("issueID is empty, create likely failed")
+		}
+		repo := copyTestRepo(t)
+		cmd := exec.Command(labBinaryPath, "issue", "close", "lab-testing", "--duplicate", "1", issueID)
+		cmd.Dir = repo
+
+		b, err := cmd.CombinedOutput()
+		if err != nil {
+			t.Log(string(b))
+			t.Fatal(err)
+		}
+		require.Contains(t, string(b), fmt.Sprintf("Issue #%s closed as duplicate", issueID))
+	})
+}
+
 func Test_issueCmd_noArgs(t *testing.T) {
 	repo := copyTestRepo(t)
 	cmd := exec.Command(labBinaryPath, "issue")

internal/gitlab/gitlab.go

@@ -604,6 +604,25 @@ func IssueClose(pid interface{}, id int) error {
 	return nil
 }
 
+// IssueDuplicate closes an issue as duplicate of another
+func IssueDuplicate(pid interface{}, id int, dupId string) error {
+	// Not exposed in API, go through quick action
+	body := "/duplicate " + dupId
+
+	_, _, err := lab.Notes.CreateIssueNote(pid, id, &gitlab.CreateIssueNoteOptions{
+		Body: &body,
+	})
+	if err != nil {
+		return errors.Errorf("Failed to close issue #%d as duplicate of %s", id, dupId)
+	}
+
+	issue, _, err := lab.Issues.GetIssue(pid, id)
+	if issue == nil || issue.State != "closed" {
+		return errors.Errorf("Failed to close issue #%d as duplicate of %s", id, dupId)
+	}
+	return nil
+}
+
 // IssueReopen reopens a closed issue
 func IssueReopen(pid interface{}, id int) error {
 	issue, _, err := lab.Issues.GetIssue(pid, id)