Standardize file read

Changed os.Open() to ioutil.ReadFile()

Signed-off-by: Lucas Zampieri <[email protected]>

cmd/edit_common.go

@@ -1,9 +1,8 @@
 package cmd
 
 import (
-	"bufio"
 	"fmt"
-	"os"
+	"io/ioutil"
 	"strings"
 
 	"github.com/zaquestion/lab/internal/git"
@@ -69,23 +68,16 @@ func editGetTitleDescription(title string, body string, msgs []string, nFlag int
 // remaining is the description.
 func editGetTitleDescFromFile(filename string) (string, string, error) {
 	var title, body string
+	var lines []string
 
-	file, err := os.Open(filename)
+	content, err := ioutil.ReadFile(filename)
 	if err != nil {
 		return "", "", nil
 	}
-	defer file.Close()
+	lines = strings.Split(string(content), "\n")
 
-	fileScan := bufio.NewScanner(file)
-	fileScan.Split(bufio.ScanLines)
-
-	// The first line in the file is the title.
-	fileScan.Scan()
-	title = fileScan.Text()
-
-	for fileScan.Scan() {
-		body = body + fileScan.Text() + "\n"
-	}
+	title = lines[0]
+	body = strings.Join(lines[1:], "\n")
 
 	return title, body, nil
 }

internal/gitlab/gitlab.go

@@ -155,19 +155,15 @@ func LoadGitLabTmpl(tmplName string) string {
 	}
 
 	tmplFile := filepath.Join(wd, ".gitlab", tmplName)
-	f, err := os.Open(tmplFile)
-	if os.IsNotExist(err) {
-		return ""
-	} else if err != nil {
-		log.Fatal(err)
-	}
-
-	tmpl, err := ioutil.ReadAll(f)
+	content, err := ioutil.ReadFile(tmplFile)
 	if err != nil {
+		if errors.Is(err, os.ErrNotExist) {
+			return ""
+		}
 		log.Fatal(err)
 	}
 
-	return strings.TrimSpace(string(tmpl))
+	return strings.TrimSpace(string(content))
 }
 
 var localProjects map[string]*gitlab.Project = make(map[string]*gitlab.Project)