labels: don't fetch labels in case of empty request

Check if any label is being really requested before fetching project's information. This patch improves `list` and `edit` queries by a lot, depending on the number of labels present in the project. Signed-off-by: Bruno Meneguele <[email protected]>
zaquestion · Apr 8, 2021 · 898dff8 · 898dff8
1 parent 41e9f74
commit 898dff8
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/cmd/label_list.go b/cmd/label_list.go
@@ -56,6 +56,11 @@ lab label list remote "search term"  # search "remote" for labels with "search t
 }
 
 func MapLabels(rn string, labelTerms []string) ([]string, error) {
+	// Don't bother fetching project labels if nothing is being really requested
+	if len(labelTerms) == 0 {
+		return []string{}, nil
+	}
+
 	labels, err := lab.LabelList(rn)
 	if err != nil {
 		return nil, err