Skip to content

Commit

Permalink
mr edit: Fix reviewers check
Browse files Browse the repository at this point in the history
The mr edit option --reviewers, incorrectly fails with "aborting: no
changes" because the change to the reviewers is not verified.

Add verification of the reviewers change to the "no changes" check.

Signed-off-by: Prarit Bhargava <[email protected]>
  • Loading branch information
prarit committed Mar 24, 2021
1 parent f3a38a2 commit 645c7e8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/mr_edit.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ lab MR edit <id>:<comment_id> # update a comment on MR`,

abortUpdate := (title == mr.Title && body == mr.Description &&
!labelsChanged && !assigneesChanged && !updateMilestone &&
!targetBranchChanged)
!targetBranchChanged && !reviewersChanged)
if abortUpdate {
log.Fatal("aborting: no changes")
}
Expand Down

0 comments on commit 645c7e8

Please sign in to comment.