Remove "Nashorn" JavaScript templates #8615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
approved these changes
Aug 30, 2024
thc202
changed the title
These templates are included with GraalVM JavaScript add-on which is now included by default, and should be used instead of Nashorn which will not be available once ZAP starts targeting newer Java version. Remove test that checked the scripts, no other script remains. Signed-off-by: thc202 <[email protected]>
thc202
force-pushed
the
rm-js-templates
branch
from
ed73958
to
3cdbe52
Compare
thc202
changed the title
|
Removed the test that was checking the templates, there are no other templates left. |
kingthorin
approved these changes
Aug 30, 2024
thc202
added a commit
to thc202/zap-extensions
that referenced
this pull request
Sep 11, 2024
Apply change that was done to respective core JavaScript template (no other template had any relevant changes). Part of zaproxy/zaproxy#8615. Signed-off-by: thc202 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These templates are included with GraalVM JavaScript add-on which is now included by default, and should be used instead of Nashorn which will not be available once ZAP starts targeting newer Java version.
Remove test that checked the scripts, no other script remains.