Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing field requestContext #972

Closed

Conversation

pauldes
Copy link

@pauldes pauldes commented Apr 29, 2021

Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event. This commit makes the code robust to this case.

Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event.
Copy link

@techdragon techdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know its a little detail, but this might be better if it's more explicit. To be laser focused on the "this key needs to be in the event_info dictionary". I think if "requestContext" in event_info: might be the better way to declare these conditionals.

@pauldes
Copy link
Author

pauldes commented May 1, 2021

@techdragon done, thanks for the review

@LucasHartridge
Copy link

Hey guys 👋 Can we fix conflicts and merge this one?

Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @pauldes, just going through open PRs and doing some housekeeping.
Do you want to fix the merge conflicts to get this into main branch? 😊

@pauldes
Copy link
Author

pauldes commented Apr 24, 2023

Hi @hellno, I'll pass.

@monkut
Copy link
Collaborator

monkut commented Aug 16, 2023

declined to merged (and appears to be implemented to some degree already)
closing.

@monkut monkut closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants