Enable live runs of repo maintenence job via manual trigger #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javulticat
added
needs-review
javulticat
removed
the
blocked
monkut
reviewed
Feb 6, 2024
|
Decided to merge this as it had been stalled. I've since tested and confirmed that this has had the expected effects:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on the new automated repo maintenance job added in #1296 to help with handling ancient/inactive/abandoned issues/PRs, it has been successfully completing dry-runs as expected for a while now - it has run without issue since #1298 (which fixed a typo that was causing the job to fail) was merged ~2 weeks ago, and it's currently at ~150 consecutive successful runs (and counting).
This PR represents the next step toward enabling this bit of repo maintenance automation: dry-runs are being disabled, and live runs will begin. However, to err on the side of caution, this PR is also disabling the job's schedule which causes GitHub to automatically run it every 2 hours. So, just in case a live run causes an unexpected problem, the job won't keep running every 2 hours until a PR is able to be merged.
Since the job lacks automated scheduling for now, I will manually execute the job and verify each of its runs to make sure the job worked as expected before allowing it to run again. Once the job has successfully completed enough live runs that we can be highly confident that it is consistently performing as expected, the final step will be to re-enable the schedule for this job in a subsequent PR, allowing it to run automatically once again.
Blocked by