-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AWS Lambdas ephemeral storage setting (#1120) #1125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a contributor to Zappa at this time, but I need this feature. This looks good to me, if I can help this PR along, I would be happy to spend some time on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. tested on my environment with success.
Thanks!
Hi, Can we add it to next release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great!. please merge this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to run make black
and make isort
to get past lint error.
@gbartosz can you please run the above? many thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a testcase confirming that the given cli value is properly changed and doesn't exceed the max configurable ephemeral_storage value? (throws proper error
Can you add a testcase confirming that the given cli value is properly changed and doesn't exceed the max configurable ephemeral_storage value? (throws proper error |
Hi @gbartosz @elip-OE @mdw123 |
Hi @hellno ! In case this feature is not in priority, you can add an extra conf that goes as-is into the aws API, which will be fully flexible. |
@Meepit Thanks for the PR update, closing this one. |
Description
Since march 2022 AWS allows for setting custom ephemeral storage size for Lambda (a storage mounted in a
/tmp
directory). Boto also supports this setting since v1.21.26.This PR extends zappa_settings.json with
ephemeral_storage
key with default value of{"Size": 512}
.GitHub Issues
#1120