Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS Lambdas ephemeral storage setting (#1120) #1125

Closed
wants to merge 10 commits into from

Conversation

gbartosz
Copy link

Description

Since march 2022 AWS allows for setting custom ephemeral storage size for Lambda (a storage mounted in a /tmp directory). Boto also supports this setting since v1.21.26.
This PR extends zappa_settings.json with ephemeral_storage key with default value of {"Size": 512}.

GitHub Issues

#1120

Copy link

@mdw123 mdw123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a contributor to Zappa at this time, but I need this feature. This looks good to me, if I can help this PR along, I would be happy to spend some time on it.

Copy link

@elip-OE elip-OE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tested on my environment with success.

Thanks!

@elip-OE
Copy link

elip-OE commented Jul 3, 2022

Hi, Can we add it to next release?

Copy link

@elip-OE elip-OE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great!. please merge this PR

Copy link
Collaborator

@monkut monkut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to run make black and make isort to get past lint error.

@elip-OE
Copy link

elip-OE commented Aug 24, 2022

@gbartosz can you please run the above? many thanks!

@gbartosz gbartosz requested a review from monkut August 30, 2022 07:30
@coveralls
Copy link

coveralls commented Sep 7, 2022

Coverage Status

Coverage increased (+0.01%) to 74.359% when pulling 3eebbdc on gbartosz:feature/ephemeral_storage into 048fbe4 on zappa:master.

Copy link
Collaborator

@monkut monkut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a testcase confirming that the given cli value is properly changed and doesn't exceed the max configurable ephemeral_storage value? (throws proper error

@monkut
Copy link
Collaborator

monkut commented Nov 5, 2022

@elip-OE

Can you add a testcase confirming that the given cli value is properly changed and doesn't exceed the max configurable ephemeral_storage value? (throws proper error

@hellno
Copy link
Collaborator

hellno commented May 3, 2023

Hi @gbartosz @elip-OE @mdw123
what is the status of this PR? I'm happy to merge it if we get the PR comment by @monkut in there.
(I've removed the next-release-candidate label because it's not a priority for the upcoming release, but we can get it done in the next or the one after, if this is solved 🤩)

@elip-OE
Copy link

elip-OE commented May 3, 2023

Hi @hellno !
I'm really want this feature to be released, but I can't write a testcase. It would be great if someone in the team can do it instead.

In case this feature is not in priority, you can add an extra conf that goes as-is into the aws API, which will be fully flexible.

@Meepit
Copy link
Contributor

Meepit commented Jul 27, 2023

Hi @hellno @monkut , I'm also quite keen on this feature. Given this PR seems to have gone stale, i've opened a new PR with the requested tests and validation here: #1259

@monkut
Copy link
Collaborator

monkut commented Aug 16, 2023

@Meepit Thanks for the PR update, closing this one.

@monkut monkut closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants