Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude_glob documentation #1052

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

tomdaly
Copy link
Contributor

@tomdaly tomdaly commented Oct 2, 2021

Description

Documentation contains incorrect information about exclude setting and no information about exclude_glob

Changes

  • Add exclude_glob documentation for zappa_settings.json to README
  • Update exclude documentation example to mention regex, not glob

GitHub Issues

Resolves #422

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 73.548% when pulling 7328958 on tomdaly:bugfix/422-update-exclude-docs into fff5ed8 on zappa:master.

@monkut monkut merged commit 882a4cd into zappa:master Aug 16, 2022
@tomdaly tomdaly deleted the bugfix/422-update-exclude-docs branch August 24, 2022 08:16
@willrogers
Copy link
Contributor

This is still incorrect! The exclude pattern are not regex, they are wildcards as described in the fnmatch module.

The example tests/ won't be excluded. It would if it was tests or if tests/ was in the exclude_glob array.

Ian288 pushed a commit to tackle-io/Zappa that referenced this pull request Jul 11, 2023
Update exclude_glob documentation

Co-authored-by: monkut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Migrated] s3 zip includes files that should be matched by the exclude setting
5 participants