Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Migrated] S3 Bucket for Zappa is not encrypted by default. #705

Closed
jneves opened this issue Feb 20, 2021 · 2 comments
Closed

[Migrated] S3 Bucket for Zappa is not encrypted by default. #705

jneves opened this issue Feb 20, 2021 · 2 comments
Labels
auto-closed [Bot] Closed, details in comments no-activity [Bot] Closing soon if no new activity

Comments

@jneves
Copy link
Contributor

jneves commented Feb 20, 2021

Originally from: Miserlou/Zappa#1792 by dci-aloughran

The S3 bucket used to host the zappa files is not encrypted. S3 has recently been updated to allow default server-side encryption.

Context

The ability to set S3 bucket to be encrypted by default adds a subtle but additional layer of security to your S3 buckets.

Expected Behavior

S3 bucket should be created with default encryption turned on to AES256.

Actual Behavior

S3 bucket is created with no encryption.

Possible Fix

I've added the code that sets the default encryption on the bucket to SSE AES256.

Steps to Reproduce

  1. Create a new Zappa app using this code.
  2. Create a new test project
  3. See that the bucket is now set with "Default Encryption" on, in the Bucket Properties.
monkut added a commit that referenced this issue Jul 27, 2022
@monkut
✨ add feature (#705)
ffaba3b 
- JSON unserializable content passed to asyncronous task during local develop will raise exception on purpose to allow developers to catch JSON unserializable errors during development.

:white_check_mark: add `test_async_call_arg_not_json_seralizable` testcase
:fire: remove unnecessary coding comment in `test_async.py`
@monkut monkut mentioned this issue Jul 27, 2022
Merged
monkut added a commit that referenced this issue Sep 15, 2022
@monkut @javulticat
add feature (#704) Check if args/kwargs are JSON Serializable while r…
c048ea2 
…unning locally (#1154)

* ✨ add feature (#705)
- JSON unserializable content passed to asyncronous task during local develop will raise exception on purpose to allow developers to catch JSON unserializable errors during development.

:white_check_mark: add `test_async_call_arg_not_json_seralizable` testcase
:fire: remove unnecessary coding comment in `test_async.py`

* :art: fix flake8

* :pencil: fix typo
:wrench: add specific `UnserializableJsonError` exception for clarity

* :white_check_mark: expand testcase to include custome exception, `UnserializableJsonError`.

* :art: run isort/black

* :fire: remove unnecessary assert

Co-authored-by: javulticat <[email protected]>

* :recycle: simplify `validate_json_serializable()` to accept *args, **kwargs as per review comment

* :fire: remove unnecessary import and use `object()` as unserializable_object sample.

Co-authored-by: javulticat <[email protected]>
Ian288 pushed a commit to tackle-io/Zappa that referenced this issue Jul 11, 2023
@monkut @javulticat @Ian288
add feature (zappa#704) Check if args/kwargs are JSON Serializable wh…
0d93f68 
…ile running locally (zappa#1154)

* ✨ add feature (zappa#705)
- JSON unserializable content passed to asyncronous task during local develop will raise exception on purpose to allow developers to catch JSON unserializable errors during development.

:white_check_mark: add `test_async_call_arg_not_json_seralizable` testcase
:fire: remove unnecessary coding comment in `test_async.py`

* :art: fix flake8

* :pencil: fix typo
:wrench: add specific `UnserializableJsonError` exception for clarity

* :white_check_mark: expand testcase to include custome exception, `UnserializableJsonError`.

* :art: run isort/black

* :fire: remove unnecessary assert

Co-authored-by: javulticat <[email protected]>

* :recycle: simplify `validate_json_serializable()` to accept *args, **kwargs as per review comment

* :fire: remove unnecessary import and use `object()` as unserializable_object sample.

Co-authored-by: javulticat <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Hi there! Unfortunately, this Issue has not seen any activity for at least 90 days. If the Issue is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed.

@github-actions github-actions bot added the no-activity [Bot] Closing soon if no new activity label Apr 3, 2024
@github-actions GitHub Actions
Copy link

Hi there! Unfortunately, this Issue was automatically closed as it had not seen any activity in at least 100 days. If the Issue is still relevant to the latest version of Zappa, please open a new Issue.

@github-actions github-actions bot added the auto-closed [Bot] Closed, details in comments label Apr 13, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-closed [Bot] Closed, details in comments no-activity [Bot] Closing soon if no new activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jneves