Skip to content

Commit

Permalink
Support Newest Manylinux Version for dependencies (#1083)
Browse files Browse the repository at this point in the history
* Support Newest Manylinux Version for dependencies

Zappa was hard coded to only allow Manylinux 1, 2010, and 2014.
Manylinux 2_24 is getting more traction, so dependencies are becoming incompatible with Zappa over time.
More information on new Manylinux versions can be found here - https://github.com/pypa/manylinux

An important example is Cryptography, where version 3.4.7 is the last one to support old-format linux wheels.
https://pypi.org/project/cryptography/3.4.7/#files
vs newest:
https://pypi.org/project/cryptography/#files

Tested on my env to make sure that manylinux 2_24 wheels would work without issue in Lambda

* Update core.py

Co-authored-by: hellno <[email protected]>
  • Loading branch information
phil-airship and hellno authored Dec 1, 2021
1 parent b5b80cf commit ba6c19a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions zappa/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,8 @@ def __init__(
else:
self.manylinux_suffix_start = "cp39"

# AWS Lambda supports manylinux1/2010 and manylinux2014
manylinux_suffixes = ("2014", "2010", "1")
# AWS Lambda supports manylinux1/2010, manylinux2014, and manylinux_2_24
manylinux_suffixes = ("_2_24", "2014", "2010", "1")
self.manylinux_wheel_file_match = re.compile(
f'^.*{self.manylinux_suffix_start}-(manylinux_\d+_\d+_x86_64[.])?manylinux({"|".join(manylinux_suffixes)})_x86_64[.]whl$'
)
Expand Down

0 comments on commit ba6c19a

Please sign in to comment.