fix(core): HTTP patch breaks aws-sdk v3 (or other libraries) intermittently #905
+107
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnegron
approved these changes
Oct 28, 2024
Comment on lines
+185
to
+188
| // Suppose this listener is some HTTP client library that consumes the | ||
| // response stream. We use setTimeout to recreate the scenario where | ||
| // the listener is attached AFTER the logger has already started | ||
| // consuming the stream. |
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a late listener of a third-party library (like aws-sdk v3) attached to HTTP response stream could miss data chunks that were already consumed by our HTTP logger. The fix involves:
Replacing direct
response.on('data')listener with a patchedemitfunction so that we don't attach a listener earlier than any other listenersMaintaining the original event emission behavior by calling the original
emitwith all argumentsAdding a test that verifies:
The changes also include:
text/plain; charset=utf-8to allowed content typesSee also this video (internal-only) to walk through my thought process.