Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(schema-to-ts): [PDE-5969] Minor doc updates to reference schema-to-ts package #821

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

rnegron
Copy link
Member

@rnegron rnegron commented Jul 16, 2024

  • Added schema-to-ts to workspaces key in the root package.json, so that running yarn from the root of the repo installs schema-to-ts packages as well.
    • Without this, running yarn and then yarn test would result in errors around the vitest package missing as part of the (cd schema-to-ts && yarn test) part.
  • Updated some docs to mention schema-to-ts

@rnegron rnegron requested a review from tkcranny July 16, 2024 13:38
@rnegron rnegron requested a review from a team as a code owner July 16, 2024 13:38
@rnegron
Copy link
Member Author

rnegron commented Jul 16, 2024

Adding schema-to-ts in the workspaces key in package.json causes the Node.js 16 testing issue mentioned here but running yarn install from the root of the repo does not install schema-to-ts's dependencies.

The ideal solution is to drop Node.js 16 and add schema-to-ts to workspaces.. I'll add a ticket for this so we don't forget. In the meantime, I've updated the CONTRIBUTING.md file.

@rnegron rnegron merged commit c4db162 into main Jul 16, 2024
14 checks passed
@rnegron rnegron deleted the PDE-4968-suppl branch July 16, 2024 17:21
@rnegron rnegron mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants