Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): Add docs for bulk-write support #787

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

kola-er
Copy link
Contributor

@kola-er kola-er commented May 15, 2024

No description provided.

packages/cli/README-source.md Outdated Show resolved Hide resolved
packages/cli/README-source.md Outdated Show resolved Hide resolved

It contains an idempotency `id` provided to the `create` action to identify each run's data in the bulk data.

## Bulk-Write in Create Actions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section is better placed before ## Output Fields and after ### Nested & Children (Line Item) Fields. It can still be a level-two heading, but I suggest we say ## Bulk Create Actions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make it be in between section ## Input Fields and ## Output Fields. Please, why so?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I had a typo there. It should be before ## Z Object and after ### Nested & Children (Line Item). Something like:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

packages/cli/snippets/bulk-write.js Outdated Show resolved Hide resolved
@kola-er kola-er merged commit b27903a into release-15.8.0 May 22, 2024
13 checks passed
@kola-er kola-er deleted the PDE-4993 branch May 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants