fix(core): Handle null response_content before passing to findSensitiveValues #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kola-er can you add a test case in core/test/logger.js so we don't break it by accident in the future? Thanks! |
eliangcs
reviewed
Apr 17, 2024
packages/core/test/logger.js
Outdated
| resBody: JSON.stringify(null), | ||
| }); | ||
|
|
||
| logger(message, data); |
There was a problem hiding this comment.
I removed || {} temporarily, trying to reproduce this same error:
TypeError: Cannot convert undefined or null to object
at Function.entries (<anonymous>)
at recurseExtract (/Users/eliang/Projects/zapier-platform/node_modules/@zapier/secret-scrubber/lib/utils.js:108:27)
at findSensitiveValues (/Users/eliang/Projects/zapier-platform/node_modules/@zapier/secret-scrubber/lib/index.js:50:39)
at attemptFindSecretsInStr (src/tools/create-logger.js:136:10)
I found that we need to add an await here. Otherwise, the error would be silently swallowed.
Suggested change
| logger(message, data); | |
| await logger(message, data); |
There was a problem hiding this comment.
Thanks. I updated it @eliangcs
eliangcs
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.