fix(schema): Make label & description optional for hidden actions #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
approved these changes
Sep 23, 2019
| new jsonschema.ValidationError( | ||
| `visible actions must have a label and description`, | ||
| action, | ||
| `/${_.capitalize(actionType)}Schema`, |
There was a problem hiding this comment.
Should we link to BasicDisplaySchema instead?
| `visible actions must have a label and description`, | ||
| action, | ||
| `/${_.capitalize(actionType)}Schema`, | ||
| `instance.${key}.key`, |
There was a problem hiding this comment.
Ideally, I think the path should be instance.${key}.display.label or instance.${key}.display.description to be more accurate, but I'm ok with instance.${key}.display too.
There was a problem hiding this comment.
went with instance.creates.foo.display, which is the path to where the dev will need to fix the issue. Good catch!
|
confirmed locally this works without issue in the editor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the other day that hidden triggers needed label/description. This loosens that requirement.
The one thing I still need to test is that the editor plays nicely with this. I'll do that before I merge it.